Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erc721 #164

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

erc721 #164

wants to merge 26 commits into from

Conversation

wolfy-nft
Copy link
Contributor

@wolfy-nft wolfy-nft commented Dec 18, 2024

Overview

  • ERC721ACloneable: a copy of ERC721A with Initializable
  • ERC721AQueryableCloneable: a copy of ERC721AQueryable, extends ERC721ACloneable
  • ERC721MagicDropMetadataCloneable: storage for contract metadata
  • ERC721MagicDropCloneable: biz logic (public/allowlist stages), protocol fees, extends ERC721MagicDropMetadataCloneable
  • ERC721AConduitPreapprovedCloneable: provides immediate trading on the ME seaport conduit (no approval tx required)

Tests

28 new test cases added for ERC721MagicDropCloneable
Screenshot 2024-12-09 at 8 57 55 PM

21 new tests added for ERC721MagicDropMetadataCloneable
Screenshot 2024-12-09 at 9 12 13 PM

code coverage. both should be 100% but theres an lcov bug causing missing coverage on two lines
Screenshot 2024-12-18 at 1 12 00 PM

Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Signed-off-by: Adam Wolf <wolfynft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant